Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ampd): ensure that txs get confirmed when broadcast with an ampd subcommand #597

Merged
merged 8 commits into from
Aug 23, 2024

Conversation

cgorenflo
Copy link
Contributor

No description provided.

@cgorenflo cgorenflo requested a review from a team as a code owner August 22, 2024 19:50
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 61.68831% with 59 lines in your changes missing coverage. Please review.

Project coverage is 93.70%. Comparing base (347cd15) to head (75eb7bd).
Report is 1 commits behind head on main.

Files Patch % Lines
ampd/src/commands/mod.rs 0.00% 45 Missing ⚠️
ampd/src/lib.rs 0.00% 11 Missing ⚠️
ampd/src/broadcaster/confirm_tx.rs 95.52% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   93.83%   93.70%   -0.14%     
==========================================
  Files         219      219              
  Lines       30806    30835      +29     
==========================================
- Hits        28908    28893      -15     
- Misses       1898     1942      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ampd/src/asyncutil/future.rs Show resolved Hide resolved
ampd/src/broadcaster/confirm_tx.rs Outdated Show resolved Hide resolved
ampd/src/broadcaster/confirm_tx.rs Outdated Show resolved Hide resolved
ampd/src/commands/mod.rs Outdated Show resolved Hide resolved
ampd/src/broadcaster/confirm_tx.rs Outdated Show resolved Hide resolved
@cgorenflo cgorenflo enabled auto-merge (squash) August 23, 2024 21:42
@cgorenflo cgorenflo disabled auto-merge August 23, 2024 21:44
@cgorenflo cgorenflo enabled auto-merge (squash) August 23, 2024 21:45
@cgorenflo cgorenflo merged commit 490f6f2 into main Aug 23, 2024
7 of 8 checks passed
@cgorenflo cgorenflo deleted the confirm-broadcast branch August 23, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants