Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(minor-rewards)!: set params per pool #576

Merged
merged 10 commits into from
Aug 16, 2024
Merged

feat(minor-rewards)!: set params per pool #576

merged 10 commits into from
Aug 16, 2024

Conversation

cjcobb23
Copy link
Contributor

@cjcobb23 cjcobb23 commented Aug 8, 2024 •
edited
Loading

@cjcobb23 cjcobb23 requested a review from a team as a code owner August 8, 2024 21:49
@codecov Codecov
Copy link

codecov bot commented Aug 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.75369% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.02%. Comparing base (ff214c3) to head (76c2313).
Report is 1 commits behind head on main.

Files Patch % Lines
contracts/rewards/src/contract/execute.rs 99.83% 1 Missing ⚠️
contracts/rewards/src/state.rs 98.48% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
+ Coverage   93.89%   94.02%   +0.12%     
==========================================
  Files         212      212              
  Lines       29634    30185     +551     
==========================================
+ Hits        27824    28380     +556     
+ Misses       1810     1805       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cgorenflo
cgorenflo reviewed Aug 12, 2024
View reviewed changes
contracts/rewards/src/contract.rs Outdated Show resolved Hide resolved
contracts/rewards/src/contract/execute.rs Outdated Show resolved Hide resolved
contracts/rewards/src/contract/execute.rs Outdated Show resolved Hide resolved
contracts/rewards/src/contract/execute.rs Outdated Show resolved Hide resolved
contracts/rewards/src/contract/execute.rs Outdated Show resolved Hide resolved
contracts/rewards/src/contract/migrations/v1_0_0.rs Outdated Show resolved Hide resolved
contracts/rewards/src/contract/migrations/v1_0_0.rs Outdated Show resolved Hide resolved
contracts/rewards/src/error.rs Show resolved Hide resolved
contracts/rewards/src/msg.rs Outdated Show resolved Hide resolved
contracts/rewards/src/state.rs Outdated Show resolved Hide resolved
@cjcobb23 cjcobb23 merged commit 45df3df into main Aug 16, 2024
6 checks passed
@cjcobb23 cjcobb23 deleted the rewards_refactor branch August 16, 2024 18:40
milapsheth pushed a commit that referenced this pull request Aug 26, 2024
@cjcobb23 @milapsheth
feat(minor-rewards)!: set params per pool (#576)
da2dc7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgorenflo cgorenflo cgorenflo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjcobb23 @cgorenflo