Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add only tx hash message id #528

Merged
merged 7 commits into from
Aug 15, 2024
Merged

feat: add only tx hash message id #528

merged 7 commits into from
Aug 15, 2024

Conversation

raress96
Copy link
Contributor

Added only tx hash message id, considering event index as 0 in events.

@raress96 raress96 requested a review from a team as a code owner July 22, 2024 12:14
cgorenflo
cgorenflo approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@cgorenflo cgorenflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor suggestions for cleaner code

packages/axelar-wasm-std/src/msg_id/tx_hash.rs Outdated Show resolved Hide resolved
@k4m4 k4m4 mentioned this pull request Jul 23, 2024
Closed
4 tasks
@raress96 raress96 requested review from k4m4 and cgorenflo July 24, 2024 08:15
cjcobb23
cjcobb23 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@cjcobb23 cjcobb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but please follow up with another PR about the event refactor when you can

@raress96 raress96 changed the title feat: Add only tx hash message id feat: add only tx hash message id Jul 26, 2024
@cjcobb23 cjcobb23 merged commit 2d03c49 into axelarnetwork:main Aug 15, 2024
5 of 6 checks passed
@raress96 raress96 deleted the tx-hash-message-id branch August 16, 2024 09:29
milapsheth pushed a commit that referenced this pull request Aug 26, 2024
@raress96 @milapsheth
feat: add only tx hash message id (#528)
2d5ec03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcobb23 cjcobb23 cjcobb23 approved these changes

@k4m4 k4m4 Awaiting requested review from k4m4

@cgorenflo cgorenflo Awaiting requested review from cgorenflo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raress96 @k4m4 @cgorenflo @cjcobb23