Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove mock contracts from voting verifier tests and use mock querier update_wasm() instead #280

Merged
merged 8 commits into from
Feb 26, 2024

Conversation

eguajardo
Copy link
Contributor

Description

https://axelarnetwork.atlassian.net/browse/AXE-3236

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

@eguajardo eguajardo changed the title refactor: remove mock contracts from voting verifier tests and use mock querier update_wasm() refactor: remove mock contracts from voting verifier tests and use mock querier update_wasm() instead Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 99.56710% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.60%. Comparing base (f86bbe1) to head (66d45a6).

Files Patch % Lines
contracts/voting-verifier/src/contract.rs 99.56% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
+ Coverage   90.23%   90.60%   +0.36%     
==========================================
  Files         161      161              
  Lines       16905    17598     +693     
==========================================
+ Hits        15255    15945     +690     
- Misses       1650     1653       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eguajardo eguajardo marked this pull request as ready for review February 26, 2024 16:00
@eguajardo eguajardo requested a review from a team as a code owner February 26, 2024 16:00
contracts/voting-verifier/src/contract.rs Outdated Show resolved Hide resolved
contracts/voting-verifier/src/contract.rs Outdated Show resolved Hide resolved
contracts/voting-verifier/src/contract.rs Show resolved Hide resolved
contracts/voting-verifier/src/contract.rs Show resolved Hide resolved
contracts/voting-verifier/src/contract.rs Show resolved Hide resolved
contracts/voting-verifier/src/contract.rs Outdated Show resolved Hide resolved
contracts/voting-verifier/src/contract.rs Show resolved Hide resolved
contracts/voting-verifier/src/contract.rs Show resolved Hide resolved
contracts/voting-verifier/src/contract.rs Show resolved Hide resolved
contracts/voting-verifier/src/contract.rs Outdated Show resolved Hide resolved
@eguajardo eguajardo merged commit 155f87f into main Feb 26, 2024
7 checks passed
@eguajardo eguajardo deleted the refactor/verifier-mock-tests branch February 26, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants