Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: merge state.rs and types.rs #111

Merged
merged 15 commits into from
Sep 21, 2023
Merged

refactor: merge state.rs and types.rs #111

merged 15 commits into from
Sep 21, 2023

Conversation

cgorenflo
Copy link
Contributor

No description provided.

@cgorenflo cgorenflo requested a review from a team as a code owner September 19, 2023 21:43
@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Merging #111 (d483c14) into main (9414bcd) will decrease coverage by 0.01%.
The diff coverage is 92.72%.

@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   88.32%   88.32%   -0.01%     
==========================================
  Files         110      109       -1     
  Lines        9999     9997       -2     
==========================================
- Hits         8832     8830       -2     
  Misses       1167     1167
Files Changed Coverage Δ
ampd/src/handlers/evm_verify_msg.rs 43.49% <ø> (ø)
ampd/src/handlers/evm_verify_worker_set.rs 41.86% <ø> (ø)
contracts/connection-router/src/contract.rs 96.53% <ø> (ø)
contracts/connection-router/src/error.rs 25.00% <ø> (ø)
contracts/connection-router/src/events.rs 83.07% <ø> (ø)
contracts/connection-router/src/msg.rs 60.00% <ø> (ø)
contracts/multisig-prover/src/contract.rs 99.16% <ø> (ø)
contracts/multisig-prover/src/execute.rs 97.11% <ø> (ø)
contracts/multisig-prover/src/state.rs 100.00% <ø> (ø)
contracts/voting-verifier/src/error.rs 25.00% <ø> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Base automatically changed from AXE-1897-Give-GlobalID-structure to main September 20, 2023 19:15
fish-sammy
fish-sammy approved these changes Sep 21, 2023
View reviewed changes
contracts/connection-router/src/state.rs Outdated Show resolved Hide resolved
contracts/connection-router/src/state.rs Show resolved Hide resolved
@cgorenflo
address comments and checks
13c5eeb
@cgorenflo
Merge branch 'main' into AXE-1899-Rename-MessageID
ec05d57 
# Conflicts:
#	contracts/connection-router/src/state.rs
#	contracts/connection-router/src/types.rs
#	contracts/connection-router/tests/mock.rs
#	contracts/connection-router/tests/test.rs
@cgorenflo
fix merge conflicts
d483c14
@cgorenflo cgorenflo enabled auto-merge (squash) September 21, 2023 17:45
@cgorenflo cgorenflo merged commit 4193cbc into main Sep 21, 2023
6 of 7 checks passed
@cgorenflo cgorenflo deleted the AXE-1899-Rename-MessageID branch September 21, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcobb23 cjcobb23 cjcobb23 left review comments

@haiyizxx haiyizxx haiyizxx approved these changes

@fish-sammy fish-sammy fish-sammy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cgorenflo @fish-sammy @haiyizxx @cjcobb23