-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multisig ed25519 #110
Merged
cgorenflo
merged 10 commits into
axelarnetwork:main
from
mobilecoinofficial:multisig-ed25519
Sep 28, 2023
Merged
feat: multisig ed25519 #110
cgorenflo
merged 10 commits into
axelarnetwork:main
from
mobilecoinofficial:multisig-ed25519
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 86.85% 87.12% +0.27%
==========================================
Files 114 115 +1
Lines 11099 11372 +273
==========================================
+ Hits 9640 9908 +268
- Misses 1459 1464 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cgorenflo
requested changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest some minor adjustments, otherwise looks good to me!
cgorenflo
approved these changes
Sep 22, 2023
cjcobb23
reviewed
Sep 22, 2023
cjcobb23
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Ed25519 key support to the
multisig
contract.Todos
Steps to Test
Run
cargo test
- happy to do any manual testing if you provide guidelines/instructions on how you approach that.Expected Behaviour
The
multisig
contract should now support Ed25519 keys.Other Notes
The
multisig-prover
contract is still hardcoded to Ecdsa keys. I am not sure if it is a priority to change that.Linking to AXE-1900