Skip to content

Commit

Permalink
improve comments
Browse files Browse the repository at this point in the history
  • Loading branch information
fish-sammy committed Feb 16, 2024
1 parent 7252c5c commit b7712c7
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions ampd/src/event_processor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ where
.change_context(Error::EventStream)?;

if let StreamStatus::Active(event) = &stream_status {
// if handlers run into errors we log them and then move on to the next event
let _ = future::with_retry(
|| handler.handle(event),
// TODO: make timeout and max_attempts configurable
Expand All @@ -71,8 +72,6 @@ where
},
)
.await
// TODO: we may need to differentiate errors that we want to ignore
// and those that we want to crash the process
.tap_err(|err| {
warn!(
err = LoggableError::from(err).as_value(),
Expand Down

0 comments on commit b7712c7

Please sign in to comment.