Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose to sell players also when recent efficiency focused #237

Closed
axel3rd opened this issue Aug 4, 2022 · 1 comment
Closed

Propose to sell players also when recent efficiency focused #237

axel3rd opened this issue Aug 4, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@axel3rd
Copy link
Owner

axel3rd commented Aug 4, 2022

Currently, the transaction proposal (transactions.proposal config) for selling players is only activated when efficiency.recent.focus = false :

if (!config.isEfficiencyRecentFocus() && !players2Sell.isEmpty()) {
LOG.info("Players to sell (initial cash: {}):", budget);

Bad on average, it is always relevant when efficiency.recent.focus = true, which is the default value (since v1.6).

=> Should be activated in all cases.

@axel3rd axel3rd added the enhancement New feature or request label Aug 4, 2022
@axel3rd axel3rd added this to the 1.10 milestone Aug 4, 2022
@axel3rd axel3rd self-assigned this Aug 4, 2022
@axel3rd
Copy link
Owner Author

axel3rd commented Aug 4, 2022

Note: Added when the current championship day is > 2, to have a relevant average.

@axel3rd axel3rd changed the title Propose to sell players also when recent efficiency focussed Propose to sell players also when recent efficiency focused Aug 4, 2022
@axel3rd axel3rd closed this as completed in 6d8c89e Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant