Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wrongtype error when increment has member that is null instead of being having always a value #80

Merged
merged 3 commits into from
May 25, 2022

Conversation

abdumu
Copy link
Member

@abdumu abdumu commented May 22, 2022

  • if there was a key that has been saved with the wrong type, it gets deleted.
  • any recording method should return a value, for example, a recorded country if the country is null should be saved as 'zz'
  • fixes Github actions.

#this should fix issue #44

@abdumu abdumu requested a review from BSN4 May 22, 2022 20:30
@abdumu
Copy link
Member Author

abdumu commented May 22, 2022

I must add, that this is a non-breaking change so that it can be released as a patch version. However, future versions of laravel-visits should remove support of PHP < 8, also Laravel < 8.

@BSN4 BSN4 merged commit 0aa19ff into awssat:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants