feat!: Support uploading folders as assets #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added changes to support uploading a folder as part of asset upload. 1. UI Changes to support uploading and a new visualizer to see folder. 2. Removed the assetType validation on the backend. 3. Introduced a new lambda function to list files when an asset consists of a folder. Not done yet 1. Revisioning of folders. 2. Individual file updates for folder assets 3. Downloading the entire folder as a single zip
This change includes UI and backend changes required for supporting folder uploads. For enabling large uploads of assets we have made the following changes 1. Asset is now created before all the uploads finish: This change unavoidable since large uploads take a long time and we cant expect the user to wait that long to have preliminary asset information created. 2. Asset revisions are not supported: At the moment we have not implemented revisioning on folder assets. The asset revisions exist on S3 but not on the asset database. 3. Asset preview is no longer required while creating assets. 4. No restrictions on asset names
archieco
approved these changes
Jun 14, 2023
scheurik
pushed a commit
that referenced
this pull request
Jun 14, 2024
* feat!: Support uploading folders as assets This change includes UI and backend changes required for supporting folder uploads. For enabling large uploads of assets we have made the following changes 1. Asset is now created before all the uploads finish: This change unavoidable since large uploads take a long time and we cant expect the user to wait that long to have preliminary asset information created. 2. Asset revisions are not supported: At the moment we have not implemented revisioning on folder assets. The asset revisions exist on S3 but not on the asset database. 3. Asset preview is no longer required while creating assets. 4. No restrictions on asset names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.