feat(infra) parameterized region code #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jjbainAWS thank you for this! I will take close look here and let you know if there's any feedback soon. |
archieco
requested changes
Jan 26, 2023
| ? Date.UTC.toString() | ||
| : `${props.ssmParameterName}-${props.ssmParameterRegion}`; | ||
|
|
||
| this.ssmParameter = new cdk.custom_resources.AwsCustomResource(this, "Param", { |
There was a problem hiding this comment.
It appears that this AwsCustomResource uses an out of date nodejs runtime. This causes our cdk nag checks to fail. Could accomplish this getParameter call another way? The aws-cdk-lib/aws-ssm package maybe?
…e to nodejs18.x for cdk-nag: AwsSolutions-L1
…om/awslabs/visual-asset-management-system into jjbainAWS-feat-parameterize-region
scheurik
pushed a commit
that referenced
this pull request
Jun 14, 2024
feat(infra) parameterized region code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK: As a VAMS user, I want the region to be completely parameterized so that I can deploy into any AWS region supporting the services I use.
Hardcoded region code use has been removed and now the cdk stack reads the region code from an environment variable
AWS_REGIONTo support deployment to regions outside of us-east-1, the web access firewall (currently region locked to us-east-1) is defined in a separate stack that is configured to always deploy to us-east-1. Metadata for the web access control list used to secure the cloudfront distribution for the VAMS web application is stored in Amazon Systems Manager Parameter Store. The main stack that is deployed in your configured region uses this metadata to configure the cloudfront distribution.
The README has been updated to address the steps required to configure the region you would like to deploy to
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.