bug: Feature group_match in user_groups mode is broken
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
@ChrisPates FYI |
|
Looks good, I'll merge into a bug fix branch next week, test and hopefully release it before the end of the week as v2.0.3. |
Will release as v2.0.3 once testing completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #52, #53, referenced in #91
Description of changes:
I have specified what I believe to be the intentions of interactions between
group-match,ignore-groupsandinclude-groupsin the documentation and unit test cases. I also manually tested the different combinations and they worked as I would have expected. We would have to (should?) do some further refactoring to build comprehensive unit test cases for how the config options map to behavior.ssosync -s users_groups -g 'name:foo*'synchs all users but doesn't synch any groups despite the Google query matching and returning groups. This is because logic in above line is always returning true as written.Expected Behavior:
Above should now synchronize all groups that match.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.