Add AddClientRuntimeConfig for generic clients #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jaykumar Gosar <[email protected]>
gosar
approved these changes
Feb 11, 2023
kuhe
approved these changes
Feb 14, 2023
srchase
added a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
Co-authored-by: Jaykumar Gosar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, generic clients fail to compile. Running the following commands:
Results in compilation errors such as
[build:es] src/commands/GetCityAnnouncementsCommand.ts(55,13): error TS2339: Property 'logger' does not exist on type 'WeatherClientResolvedConfig'..This PR adds AddClientRuntimeConfig which generates client configuration that is currently added to AWS clients via AddAwsRuntimeConfig.
Co-authored-by: Jaykumar Gosar [email protected]
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.