Generic client runtime config #4427
Conversation
| @@ -74,15 +74,6 @@ public void addConfigInterfaceFields( | |||
| SymbolProvider symbolProvider, | |||
| TypeScriptWriter writer | |||
| ) { | |||
| writer.addImport("Provider", "__Provider", TypeScriptDependency.AWS_SDK_TYPES.packageName); | |||
There was a problem hiding this comment.
Update the javadoc to reflect the changes.
| @@ -35,7 +35,7 @@ public void awsClient() { | |||
|
|
|||
| // Check dependencies | |||
| assertThat(manifest.getFileString("package.json").get(), | |||
| containsString(AwsDependency.NODE_CONFIG_PROVIDER.packageName)); | |||
| containsString(TypeScriptDependency.NODE_CONFIG_PROVIDER.packageName)); | |||
There was a problem hiding this comment.
update the tests to not assert for things that are not part of its logic.
| writer.writeDocs("Enables IPv6/IPv4 dualstack endpoint.") | ||
| .write("useDualstackEndpoint?: boolean | __Provider<boolean>;\n"); | ||
| writer.writeDocs("Enables FIPS compatible endpoints.") |
There was a problem hiding this comment.
While we are updating this, let's make the Integration be appropriately conditional. On the aws.api#service trait.
There was a problem hiding this comment.
In fact, given these are AWS specific, maybe they should just be folded into AddAwsRuntimeConfig.
There was a problem hiding this comment.
Moved into AddAwsRuntimeConfig and made appropriately conditional in 3e1cb31.
srchase
force-pushed
the
generic-client-runtime-config
branch
from
2ed2fd0 to
3e1cb31
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This PR updates client configuration to use the client config that was moved to smithy-typescript in smithy-lang/smithy-typescript#693
Clients were re-generated, due to the change in ordering of the generated config, but the content is the same.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.