Update float/int parsing and expectations #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
force-pushed
the
strict-parse-numbers
branch
2 times, most recently
from
edaba4e to
2dccc96
Compare
|
Should you just change int/float? Eventually we're going to have to handle underflow/overflow, and if we put that in the parse method, you're going to have to change this again. |
Incremental progress is still progress. Sure we'll add parse/expect short/byte/etc later |
adamthom-amzn
approved these changes
Aug 11, 2021
This updates number parsing in http bindings to be more strict. It also updates the expectation methods used for numbers to be more specific.
JordonPhillips
force-pushed
the
strict-parse-numbers
branch
from
2dccc96 to
e0875a2
Compare
trivikr
approved these changes
Aug 19, 2021
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
This updates number parsing in http bindings to be more strict. It also updates the expectation methods used for numbers to be more specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates number parsing to be more strict. It also updates the expectation methods used for numbers to be more specific.
This relies on: aws/aws-sdk-js-v3#2662
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.