chore(clients): parse numbers more strictly #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2662 +/- ##
=======================================
Coverage ? 60.73%
=======================================
Files ? 521
Lines ? 27833
Branches ? 6847
=======================================
Hits ? 16904
Misses ? 10929
Partials ? 0 Continue to review full report at Codecov.
|
JordonPhillips
force-pushed
the
strict-parse-numbers
branch
from
33ad392 to
1f5dc34
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
adamthom-amzn
approved these changes
Aug 12, 2021
trivikr
reviewed
Aug 12, 2021
This provides methods to more strictly parse floats and ints. The strict float parser only allows explicit NaN and does not attempt to parse non-string, non-number values. The strict int parser disallows NaN entirely, and will opt to error if there are any decimals present. It also will noot parse non-string, non-number values.
JordonPhillips
force-pushed
the
strict-parse-numbers
branch
from
1f5dc34 to
57e6cbe
Compare
trivikr
approved these changes
Aug 19, 2021
trivikr
changed the title
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
n/a
Description
This provides methods to more strictly parse floats and ints. The strict float parser only allows explicit NaN and does not attempt to parse non-string, non-number values. The strict int parser disallows NaN entirely, and will opt to error if there are any decimals present. It also will not parse non-string, non-number values.
Testing
Unit tests were added for new methods. This also fixes a number of generated tests not released yet in Smithy.
Additional context
JS is very loose about what it will convert to a number, and we don't want to be nearly so loose, especially in the SSDK.
Related: smithy-lang/smithy-typescript#397
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.