Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bignum_{sqr,mul}_p521_neon #130

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

aqjune-aws
Copy link
Collaborator

This adds bignum_{sqr,mul}_p521_neon and their proofs.

The new subroutine specs are added to specification.txt, and test as well as benchmark are updated.

Benchmark results on GV2 are:

bignum_mul_p521                 :   135.1 ns each (var  0.2%, corr -0.01) =    7404184 ops/sec
bignum_mul_p521_neon            :   115.5 ns each (var  0.3%, corr  0.00) =    8660108 ops/sec
bignum_sqr_p521                 :   108.9 ns each (var  0.2%, corr  0.08) =    9184994 ops/sec
bignum_sqr_p521_neon            :    78.7 ns each (var  0.3%, corr  0.06) =   12708368 ops/sec

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This adds `bignum_{sqr,mul}_p521_neon` and their proofs.

The new subroutine specs are added to specification.txt, and test as well as benchmark are updated.

Benchmark results on GV2 are:

```
bignum_mul_p521                 :   135.1 ns each (var  0.2%, corr -0.01) =    7404184 ops/sec
bignum_mul_p521_neon            :   115.5 ns each (var  0.3%, corr  0.00) =    8660108 ops/sec
bignum_sqr_p521                 :   108.9 ns each (var  0.2%, corr  0.08) =    9184994 ops/sec
bignum_sqr_p521_neon            :    78.7 ns each (var  0.3%, corr  0.06) =   12708368 ops/sec
```
@aqjune-aws aqjune-aws marked this pull request as ready for review June 26, 2024 04:28
Copy link
Contributor

@jargh jargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine, and the performance update is very good, thank you!

@aqjune-aws aqjune-aws merged commit b559a56 into awslabs:main Jun 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants