[Compatible] Fix batch_matmul from Relay #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comaniac
added a commit
to comaniac/raf
that referenced
this pull request
Feb 24, 2023
This reverts commit 51ec502.
comaniac
added a commit
that referenced
this pull request
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
apache/tvm#13927 changes the logic of converting PyTorch batch_matmul to Relay. Specifically, it uses Relay's batch_matmul attribute
transpose_bto avoid explicitly adding a transpose op. However, the current logic of converting Relay to RAF doesn't consider this attribute and results in incorrect IRs.This PR thus fixes the Relay to RAF conversion logic to dispatch Relay batch_matmul to one of batch_matmul_xy ops.
Checklist
cc @awslabs/raf-reviewer