PoC to buffer write requests #854
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Passaro <[email protected]>
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
reviewed
Apr 16, 2024
| @@ -11,6 +11,7 @@ description = "High-performance Amazon S3 client for Mountpoint for Amazon S3." | |||
| mountpoint-s3-crt = { path = "../mountpoint-s3-crt", version = "0.7.0" } | |||
| mountpoint-s3-crt-sys = { path = "../mountpoint-s3-crt-sys", version = "0.7.0" } | |||
|
|
|||
| async-channel = "2.1.1" | |||
There was a problem hiding this comment.
Is the channel provided by tokio (which we already have a dep on) useful here?
vladem
reviewed
Apr 16, 2024
| .write(slice, false) | ||
| .await | ||
| .map_err(S3RequestError::CrtError)?; | ||
| // Send data to the write queue. |
There was a problem hiding this comment.
the backpressure is not implemented in any form with this change, right? was it the same before switching to async write API?
By not having backpressure I mean that write() syscalls complete as soon as they've buffered data in RAM, user application has no way of finding out that S3 requests do not adjust to their writing speed and the buffer just keeps growing. This is the behaviour now and before the async write API?
|
Dropping in favor of #874. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer write requests into part-size buffers before sending them to the CRT client.
Draft: it will need some tidy up and fixing test failures (cancellation/error reporting).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).