Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --sse, --sse-kms-key-id flags under a feature flag #715

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

vladem
Copy link
Contributor

@vladem vladem commented Jan 25, 2024

Description of change

  1. Pass --sse, --sse-kms-key-id to the S3CrtClient (changes are added under a compile-time feature flag);
  2. Add happy test to fuse_tests/write_test.rs that uses IAM session policies;
  3. Add error tests to fuse_tests/fork_test.rs that check error logs.

Thinking of adding the checksumming logic in a separate PR.

Relevant issues: #534

Does this change impact existing behavior?

This is not a breaking change.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@vladem vladem temporarily deployed to PR integration tests January 25, 2024 12:18 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 25, 2024 12:18 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 25, 2024 12:18 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 25, 2024 12:18 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 25, 2024 12:18 — with GitHub Actions Inactive
@vladem vladem marked this pull request as draft January 25, 2024 12:25
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 10:38 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 10:38 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 10:38 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 10:38 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 10:38 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 10:53 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 10:53 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 10:53 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 10:53 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 10:53 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 10:53 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 16:42 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 16:42 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 16:42 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 16:42 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 16:42 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 16:42 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 26, 2024 16:42 — with GitHub Actions Inactive
@vladem vladem marked this pull request as ready for review January 29, 2024 16:42
@vladem vladem temporarily deployed to PR integration tests February 8, 2024 18:55 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 8, 2024 18:55 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 8, 2024 18:55 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 8, 2024 18:55 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 8, 2024 18:55 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 8, 2024 18:55 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 8, 2024 20:53 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 8, 2024 20:53 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 8, 2024 20:53 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 8, 2024 20:53 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 8, 2024 20:53 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 8, 2024 20:53 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 9, 2024 15:05 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 9, 2024 15:05 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 9, 2024 15:05 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 9, 2024 15:05 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 9, 2024 15:05 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 9, 2024 15:05 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests February 9, 2024 15:05 — with GitHub Actions Inactive
@vladem vladem requested a review from passaro February 9, 2024 15:22
@passaro passaro self-requested a review February 9, 2024 15:33
@vladem vladem added this pull request to the merge queue Feb 9, 2024
Merged via the queue into awslabs:main with commit 0b980a0 Feb 9, 2024
24 checks passed
@vladem vladem deleted the sse-kms-mp branch February 9, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants