Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyTorch example to support single files and different models #603

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

jamesbornholt
Copy link
Member

@jamesbornholt jamesbornholt commented Nov 14, 2023

We'd like to expand our testing to single files rather than only sharded representations. This change adds the ability to create and train against that style of dataset. It also adds some other useful configurations for Mountpoint training and for configuring a different model to train rather than hardcoding ResNet-50.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@jamesbornholt jamesbornholt temporarily deployed to PR integration tests November 14, 2023 05:54 — with GitHub Actions Inactive
@jamesbornholt jamesbornholt temporarily deployed to PR integration tests November 14, 2023 05:54 — with GitHub Actions Inactive
@jamesbornholt jamesbornholt temporarily deployed to PR integration tests November 14, 2023 05:54 — with GitHub Actions Inactive
@jamesbornholt jamesbornholt temporarily deployed to PR integration tests November 14, 2023 19:27 — with GitHub Actions Inactive
@jamesbornholt jamesbornholt temporarily deployed to PR integration tests November 14, 2023 19:27 — with GitHub Actions Inactive
@jamesbornholt jamesbornholt temporarily deployed to PR integration tests November 14, 2023 19:27 — with GitHub Actions Inactive
@jamesbornholt jamesbornholt temporarily deployed to PR integration tests November 14, 2023 19:27 — with GitHub Actions Inactive
@jamesbornholt jamesbornholt marked this pull request as ready for review November 15, 2023 04:31
Copy link
Contributor

@monthonk monthonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! left a few minor comments.

I also got error ModuleNotFoundError: TorchData must be built with BUILD_S3=1 to use this datapipe while testing s3io job, not sure if it's related to this change though.

examples/pytorch/resnet.py Outdated Show resolved Hide resolved
examples/pytorch/resnet.py Outdated Show resolved Hide resolved
We'd like to expand our testing to single files rather than only sharded
representations. This change adds the ability to create and train
against that style of dataset. It also adds some other useful
configurations for Mountpoint training and for configuring a different
model to train rather than hardcoding ResNet-50.

Signed-off-by: James Bornholt <[email protected]>
@jamesbornholt
Copy link
Member Author

I also got error ModuleNotFoundError: TorchData must be built with BUILD_S3=1 to use this datapipe while testing s3io job, not sure if it's related to this change though.

No, not related -- the torchdata install in the DLAMI isn't built with S3IO support, you have to uninstall and reinstall it from pip. Kinda annoying.

Signed-off-by: James Bornholt <[email protected]>
@jamesbornholt jamesbornholt temporarily deployed to PR integration tests December 8, 2023 01:04 — with GitHub Actions Inactive
@jamesbornholt jamesbornholt temporarily deployed to PR integration tests December 8, 2023 01:04 — with GitHub Actions Inactive
@jamesbornholt jamesbornholt temporarily deployed to PR integration tests December 8, 2023 01:04 — with GitHub Actions Inactive
@jamesbornholt jamesbornholt temporarily deployed to PR integration tests December 8, 2023 01:04 — with GitHub Actions Inactive
@jamesbornholt jamesbornholt temporarily deployed to PR integration tests December 8, 2023 01:04 — with GitHub Actions Inactive
@jamesbornholt jamesbornholt temporarily deployed to PR integration tests December 8, 2023 01:04 — with GitHub Actions Inactive
@jamesbornholt jamesbornholt temporarily deployed to PR integration tests December 8, 2023 01:04 — with GitHub Actions Inactive
@monthonk monthonk added this pull request to the merge queue Dec 8, 2023
Merged via the queue into awslabs:main with commit 342b256 Dec 8, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants