Add a CI job to validate Graviton instance support #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Monthon Klongklaew <[email protected]>
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Closed
jamesbornholt
approved these changes
May 17, 2023
dannycjones
reviewed
May 18, 2023
Comment on lines
+87
to
+88
| name: Tests (arm64) | ||
| runs-on: [self-hosted, linux, arm64] |
There was a problem hiding this comment.
If we also have x86_64 self-hosted runners, can we just add ARM and x86 to the strategy matrix and reuse the workflow?
There was a problem hiding this comment.
I'm not entirely sure, but from examples in github docs I believe we can.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make sure that Mountpoint can be built and run on aarch64 and Graviton instances, but GitHub currently doesn't support this type of runner. What we can do for now is using self-hosted runners, which we maintain internally, until GitHub provides official ARM-based images.
The current configuration for our runners is m7g.medium instance type with Amazon Linux 2 operating system.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).