Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an expected bucket owner test #1241

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vladem
Copy link
Contributor

@vladem vladem commented Jan 22, 2025

Add the expected bucket owner test. The test attempts to use a bucket in another AWS account as a cache and verifies that:

  • write to the cache is not done if the expected bucket owner check is enabled
  • write to the cache is done if the check is disabled
  • write to the cache is done if the cache bucket belongs to the expected account

Does this change impact existing behavior?

No.

Does this change need a changelog entry? Does it require a version change?

No.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

Signed-off-by: Vlad Volodkin <[email protected]>
@vladem vladem had a problem deploying to PR integration tests January 22, 2025 15:49 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests January 22, 2025 15:49 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests January 22, 2025 15:49 — with GitHub Actions Failure
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 15:49 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 15:49 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 15:49 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 15:49 — with GitHub Actions Inactive
@vladem vladem marked this pull request as draft January 22, 2025 16:15
Signed-off-by: Vlad Volodkin <[email protected]>
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 16:33 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 16:33 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 16:33 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 16:33 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 16:33 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 16:33 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 16:33 — with GitHub Actions Inactive
@vladem vladem marked this pull request as ready for review January 22, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant