Address shadowing divergence in reftest, update semantics doc #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
force-pushed
the
semantics-document-reftest-fix
branch
from
b3d7045 to
f405d75
Compare
c-hagem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
c-hagem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
c-hagem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
c-hagem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
c-hagem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
c-hagem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
c-hagem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
changed the title
dannycjones
requested changes
Dec 13, 2024
|
This PR closes #1066. |
This commit addresses a case where MP model and property tests diverge (awslabs#1066). The issue was caused by the reference not correctly implementing the shadowing order defined in [#4f8cf0b](awslabs@4f8cf0b). Additionally, it clarifies the Semantics arising from concurrent MPUs. Signed-off-by: Christian Hagemeier <[email protected]>
c-hagem
force-pushed
the
semantics-document-reftest-fix
branch
from
f405d75 to
c5f1469
Compare
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
muddyfish
reviewed
Dec 17, 2024
doc/SEMANTICS.md
Outdated
| @@ -74,7 +74,7 @@ Mountpoint allows multiple readers to access the same object at the same time. | |||
| However, a new file can only be written to sequentially and by one writer at a time. | |||
| New files that are being written are not available for reading until the writing application closes the file and Mountpoint finishes uploading it to S3. | |||
| If you have multiple Mountpoint mounts for the same bucket, on the same or different hosts, there is no coordination between writes to the same object. | |||
| Your application should not write to the same object from multiple instances at the same time. | |||
| Your application should not write to the same object from multiple instances at the same time. If you use multiple instances for writing the same key (or another client modifies the Object while the file is open for writing), be aware that Mountpoint currently uses Multipart Uploads (MPU) that are created after the file is opened to upload the data to S3. | |||
There was a problem hiding this comment.
Why does Mountpoint using MPU matter? What are the consequences you might need to be aware of?
dannycjones
reviewed
Dec 17, 2024
Remove comments unrelated to shadowing. Signed-off-by: Christian Hagemeier <[email protected]>
c-hagem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
c-hagem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
c-hagem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
c-hagem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
c-hagem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
c-hagem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
c-hagem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
approved these changes
Dec 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses a case where MP model and property tests diverge (#1066). The issue was caused by the reference not correctly implementing the shadowing order defined in #4f8cf0b. This commit fixes the reference model, and clarifies the semantics arising from concurrent MPUs.
This is not a breaking change, as it only impacts the reference tests.
This does not need a Changelog entry, as the change does not impact Mountpoint's behaviour.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).