Add errno to fuse_error macro #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Renan Magagnin <[email protected]>
renanmagagnin
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
renanmagagnin
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
renanmagagnin
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Signed-off-by: Renan Magagnin <[email protected]>
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
approved these changes
Dec 6, 2024
passaro
reviewed
Dec 6, 2024
| @@ -810,7 +810,7 @@ fn read_with_no_permissions_for_a_key_sse() { | |||
| read_result.expect("should be able to read a default-encrypted file after the first read failure"); | |||
| } | |||
|
|
|||
| let log_line_pattern = format!("^.*WARN.*{encrypted_object}.*read failed: get request failed: get object request failed: Client error: Forbidden: User: .* is not authorized to perform: kms:Decrypt on resource: {key_id} because no session policy allows the kms:Decrypt action.*$"); | |||
| let log_line_pattern = format!("^.*WARN.*{encrypted_object}.*read 5 failed: get request failed: get object request failed: Client error: Forbidden: User: .* is not authorized to perform: kms:Decrypt on resource: {key_id} because no session policy allows the kms:Decrypt action.*$"); | |||
There was a problem hiding this comment.
The error message does not look right. Why are we adding the error number here?
There was a problem hiding this comment.
We had a chat, we're probably looking for something like "read failed returning errno 5"
There was a problem hiding this comment.
It may be worth taking a look at this libc(?) function that can return a string form of the error: https://man7.org/linux/man-pages/man3/errno.3.html. Or maybe we just do something Rust-side.
The idea is if we can instead get to something like:
"read failed returning EPERM"
There was a problem hiding this comment.
Oops, see we're already working in this PR: #1197
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
This change improves the clarity of [fuse_error with errono](#1189). ### Does this change impact existing behavior? No ### Does this change need a changelog entry? No --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Signed-off-by: Renan Magagnin <[email protected]> Co-authored-by: Alessandro Passaro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added errno to fuse_error macro
Does this change impact existing behavior? No
Does this change need a changelog entry? No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).