Refactor ObjectClient.get_object to use an GetObjectParams parameter
#1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Beal <[email protected]>
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
reviewed
Nov 8, 2024
Signed-off-by: Simon Beal <[email protected]>
Signed-off-by: Simon Beal <[email protected]>
Signed-off-by: Simon Beal <[email protected]>
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Refactor
ObjectClient.get_objectto use an&GetObjectParamsparameter.Migrates the two existing parameters,
rangeandif_matchtoGetObjectParamsand changes all call sites.Relevant issues: N/A
Does this change impact existing behavior?
No
Does this change need a changelog entry in any of the crates?
Yes. Breaking change in mountpoint-s3-client.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).