Don't run benchmarks with debug, plus minor refactoring #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpeace
had a problem deploying
to
PR benchmarks
GitHub Actions
Failure
adpeace
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
adpeace
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
adpeace
had a problem deploying
to
PR benchmarks
GitHub Actions
Failure
adpeace
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
adpeace
had a problem deploying
to
PR benchmarks
GitHub Actions
Failure
adpeace
had a problem deploying
to
PR benchmarks
GitHub Actions
Failure
adpeace
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
adpeace
had a problem deploying
to
PR benchmarks
GitHub Actions
Failure
adpeace
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
adpeace
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
adpeace
had a problem deploying
to
PR benchmarks
GitHub Actions
Failure
adpeace
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
reviewed
Nov 6, 2024
`read` and `write` were almost identical, so merge them into a single `run_benchmarks` method that is parameterized. Signed-off-by: Andrew Peace <[email protected]>
Previously, --debug was being passed to the mount command. As this might impact performance, this change removes it. We also add a new environment variable, S3_DEBUG, which can be used to add this back again if needed (just set it to a non-empty value). Signed-off-by: Andrew Peace <[email protected]>
adpeace
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
adpeace
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
adpeace
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
adpeace
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
adpeace
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
adpeace
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
adpeace
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
## Description of change We opted to disable debug logging in #1104 as this may impact performance, however it was not known that the memory usage monitoring was dependent on metrics being emitted implicitly due to `--debug`. This change restores metrics in logs to fix the peak memory usage benchmarking. Relevant issues: #1104 ## Does this change impact existing behavior? No change to Mountpoint. ## Does this change need a changelog entry in any of the crates? No. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Signed-off-by: Daniel Carl Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Remove the
--debugflag when mounting S3 for the benchmarks.This is now available via an S3_DEBUG environment variable which, when set, will add
--debugback again.Also, within
fs_bench.sh, merge the read and write benchmark methods into a single one, which is paramterized, since they were almost identical. This avoids having to make the change described above in two places and simplifies the code going forwards.Does this change impact existing behavior?
This changes the benchmarks to run without --debug to the mount command, which creates a discontinuity in benchmark results, and may improve them (though there's no actual performance improvement here).
Does this change need a changelog entry in any of the crates?
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).