Remove use of ObjectInfo in S3 client HeadObject response #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
force-pushed
the
decouple-object-info-headobject
branch
from
65832aa to
5871746
Compare
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
force-pushed
the
decouple-object-info-headobject
branch
from
5871746 to
2592dad
Compare
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
force-pushed
the
decouple-object-info-headobject
branch
from
2592dad to
fefd08b
Compare
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
auto-merge was automatically disabled
October 23, 2024 12:39
Pull request was converted to draft
dannycjones
force-pushed
the
decouple-object-info-headobject
branch
from
68d2190 to
bf31709
Compare
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Signed-off-by: Daniel Carl Jones <[email protected]>
dannycjones
force-pushed
the
decouple-object-info-headobject
branch
from
bf31709 to
6ba3323
Compare
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Before this change,
head_objectandlist_objectsshared the same structObjectInfo. The data we returned from these two operations was common, and so it worked well. Now we want to add information that is specific to the two operations.This change leaves
ObjectInfoin place forlist_objects, aligning with the Object structure in the Rest XML API.This change is in preparation to surfacing checksum algorithm from ListObjectsV2 requests as well as surfacing checksum values in HeadObject requests.
Relevant issues: N/A
Does this change impact existing behavior?
There is no breaking changes to Mountpoint's file system semantics.
This is a breaking change to direct consumers of Mountpoint's S3 client. The
head_objectreturn typeHeadObjectResultwill no longer have anobjectfield of typeObjectInfo. Accesses to those fields should now be on theHeadObjectResultstruct itself.Does this change need a changelog entry in any of the crates?
Yes. A change log entry is added to the
mountpoint-s3-clientcrate.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).