feat(components)!: introduce new table component #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 32a44855efe10c00b3e14b98079dc428ab8b3075 into 0edf35c - view on LGTM.com new alerts:
|
square-li
force-pushed
the
feature-table
branch
from
32a4485 to
c874f2a
Compare
|
This pull request introduces 1 alert when merging c874f2a96e31ab3ca8103e765cbde953f8355a78 into 0edf35c - view on LGTM.com new alerts:
|
square-li
force-pushed
the
feature-table
branch
2 times, most recently
from
4378325 to
9ecd85f
Compare
|
This pull request introduces 1 alert when merging 9ecd85f6ce0200f068c5091d2804e8585538e2d0 into 0edf35c - view on LGTM.com new alerts:
|
square-li
force-pushed
the
feature-table
branch
2 times, most recently
from
dbb89a8 to
c68798e
Compare
|
This pull request introduces 1 alert when merging c68798e894829ab3cfd2c8d081bf1151f44b4208 into 0edf35c - view on LGTM.com new alerts:
|
square-li
changed the title
diehbria
requested changes
Aug 30, 2022
packages/components/src/components/iot-table/iot-react-table.tsx
Outdated
Show resolved
Hide resolved
square-li
changed the title
square-li
changed the title
square-li
force-pushed
the
feature-table
branch
2 times, most recently
from
7d34ae6 to
48f9e70
Compare
square-li
changed the title
square-li
changed the title
|
This pull request introduces 1 alert when merging 48f9e70aab0df2e411dc0dbfb3ed5b91ea2fe96c into 355f57e - view on LGTM.com new alerts:
|
square-li
force-pushed
the
feature-table
branch
from
48f9e70 to
41834d1
Compare
|
This pull request introduces 1 alert when merging 41834d1a7e875addd11c58435d8675d3d8366ebb into 355f57e - view on LGTM.com new alerts:
|
square-li
force-pushed
the
feature-table
branch
from
41834d1 to
e22fa3a
Compare
|
This pull request introduces 1 alert when merging e22fa3ae1e3de5732e673b189a7cef10cf2d0abd into 11f7fb0 - view on LGTM.com new alerts:
|
diehbria
previously approved these changes
Sep 7, 2022
packages/table/README.md
Outdated
| #### Install | ||
| In the root folder of `iot-app-kit`, run | ||
| ```bash | ||
| lerna bootstrap |
There was a problem hiding this comment.
main branch has moved from lerna
|
This pull request introduces 1 alert when merging de1d5c1210fd81599afc0e582e1d13b756d7b877 into b7a1fc3 - view on LGTM.com new alerts:
|
square-li
force-pushed
the
feature-table
branch
from
de1d5c1 to
ff7733f
Compare
boweihan
previously approved these changes
Sep 13, 2022
square-li
force-pushed
the
feature-table
branch
2 times, most recently
from
6435ee3 to
1101f12
Compare
|
This pull request introduces 1 alert when merging 1101f12d6b57ec2491794f532a266ca1481626c0 into 7839aef - view on LGTM.com new alerts:
|
square-li
force-pushed
the
feature-table
branch
from
1101f12 to
fceb191
Compare
|
This pull request introduces 1 alert when merging 277ecd89f2230e2d1d4ea64162e878c7402c6dbd into 7839aef - view on LGTM.com new alerts:
|
diehbria
previously approved these changes
Sep 13, 2022
- config typescript & rollup - config jest - config eslint - add unit tests for createTableItems method - updated .eslintrc.js at project root level fix: update tsconfig path in eslintrc for Table package. - remove unused variables. fix: add tests for dataFilters.ts - update descriptions for tests in createTableItems.spec.ts - add one test case for getting data point from aggregated datastream fix: remove unnecessary describe block fix: use object to replace CellItem class - add createCellItem function - add unit tests for createCellItem - rename SC_DataStream to SynchroChartsDataStream for better consistency fix: remove unused import - update createCellItem tests.
awslabs#129) feat: add helper functions for - iconUtils.tsx - copied from synchro-charts with changes. - iconUtils.spec.ts - copied from synchro-charts with changes: -- add one test cases, that color are provided, compared with the original. - spinner.tsx - copied from synchro-charts with adjustments for React - spinner.spec.tsx - copied from synchro-charts with adjustments for React feat: add the main table component fix: remove generic types for TableProps fix: add size to loading spinner fix: remove unnecessary TS compiler options update a few things based on comments from PR. Fix: remove full file eslint disable. Switch to minimal eslint disable.
…n TableItems (awslabs#146) fix: remove unused variables.
…wslabs#147) * feat: Replace iot-table with new version. * Update autogenerated types * fix import * another fix for import * another fix for import * Remove unused property for Iot. * Fix a typo * Code cleanups. * Code cleanups. * update type of `ColumnDefinition.formatter` also added a few use cases in testing-ground.tsx * update type of `ColumnDefinition.formatter` also added a few use cases in testing-ground.tsx * Update asset/property IDs and table examples. * update: add formatter to filterOptions Property filtering options now has the same displayed value as table. * update formatPropertyFilterOptions function to better handle error & loading states. * update test examples for table component. * Disable Customized formatter for property filter options. * update test cases after disabled formatter for filter options * Remove unused dependency. * a few bug fixes - Split sorting and propertyFiltering - Remove formatting on property filtering options. * UI adjustment - center icon and string vertically. * Update styles and unit tests * Remove unused imports and statements. * Reformat css file * Restore testing ground
* Update docs. Add README.md for new table component.
- render correct data based on different viewports - render spinner when a datastream is loading - render error icon and message when a datastream in error state - render icon and apply styles when it breaches thresholds
- clean git history and update doc - removed unused method in `iot-react-table.tsx`
- updated docs - export `dataFilters` from core and removed duplications from table. - update npm-publish.yml - update table styles - iot-table: watch messageOverrides for changes
square-li
force-pushed
the
feature-table
branch
from
277ecd8 to
8f4f615
Compare
|
This pull request introduces 1 alert when merging 8f4f615 into 7839aef - view on LGTM.com new alerts:
|
diehbria
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Introduce new table component to IoT App Kit.
iot-tablecomponent now uses the new table component instead of Synchro-chart's table component to support filtering and sorting.BREAKING CHANGE
@iot-app-kit/components/iot-tablenow uses AWS-UI's table components (wrapped as a separated table package) instead of Synchro-chart's table component.Because of this change, we have new APIs for iot-table component. Check this documentation for more information about new APIs and migration from old APIs.
iot-tabledoes NOT support viewport groups. It will be added in a later version.Original PR: #184
Clean up git history by rebasing.
Legal
This project is available under the Apache 2.0 License.