Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor related-table tests to use create root #105

Closed
diehbria opened this issue May 17, 2022 · 2 comments
Closed

Refactor related-table tests to use create root #105

diehbria opened this issue May 17, 2022 · 2 comments

Comments

@diehbria
Copy link
Contributor

Is your feature request related to a problem? Please describe.
ReactDOM.render is no longer supported in react 18, but is utilized in the related table tests.

This causes the following warning

 Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more: https://reactjs.org/link/switch-to-createroot

Describe the solution you'd like
Follow guide https://reactjs.org/link/switch-to-createroot
@diehbria diehbria added enhancement New feature or request and removed enhancement New feature or request labels May 17, 2022
@square-li square-li mentioned this issue Jul 8, 2022
Merged
@square-li
Copy link
Contributor

fixed by #151

@sheilaXu
Copy link
Contributor

This fix is reverted in #150 because it's incompatible with react v17 and we want to continue with v17 for the reason mentioned in the PR.

@sheilaXu sheilaXu reopened this Jul 14, 2022
sheilaXu added a commit that referenced this issue Sep 23, 2022
@sheilaXu
Add multi-property query support (#105)
9020c2f 
Co-authored-by: Xinyi Xu <[email protected]>
@divya-sea divya-sea mentioned this issue Sep 19, 2023
Merged
@ssjagad ssjagad mentioned this issue Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sheilaXu @square-li @diehbria