fix(NO-ISSUE): Fix selection bug (#53)

Co-authored-by: Mitchell Lee <[email protected]>
awslabs · Aug 15, 2022 · faacba5 · faacba5
1 parent 6e59913
commit faacba5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/packages/scene-composer/jest.config.ts b/packages/scene-composer/jest.config.ts
@@ -29,7 +29,7 @@ export default merge.recursive(tsPreset, awsuiPreset, {
     '^.+\\.(js|jsx)$': 'babel-jest',
     '\\.(ts|tsx)$': 'ts-jest',
   },
-  transformIgnorePatterns: ['<rootDir>/build', '<rootDir>/coverage'],
+  transformIgnorePatterns: ['<rootDir>/build', '<rootDir>/coverage', '<rootDir>/dist'],
   testPathIgnorePatterns: ['node_modules', 'dist'],
   moduleDirectories: ['node_modules', '<rootDir>'],
   moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx'],

diff --git a/packages/scene-composer/package.json b/packages/scene-composer/package.json
@@ -152,10 +152,10 @@
   "jest": {
     "coverageThreshold": {
       "global": {
-        "lines": 77.42,
-        "statements": 76.59,
-        "functions": 76.5,
-        "branches": 62.85,
+        "lines": 77.48,
+        "statements": 76.62,
+        "functions": 76.53,
+        "branches": 63.02,
         "branchesTrue": 100
       }
     }

diff --git a/packages/scene-composer/src/components/three-fiber/EntityGroup/index.tsx b/packages/scene-composer/src/components/three-fiber/EntityGroup/index.tsx
@@ -52,6 +52,7 @@ const EntityGroup = ({ node }: IEntityGroupProps) => {
 
   const onClick = useCallback(
     (e) => {
+      e.stopPropagation(); // the most nested object in the click scope should get selected, and not bubble up to the parent.
       if (selectedSceneNodeRef === nodeRef) {
         setSelectedSceneNodeRef(undefined);
       } else {