This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
feat: support Period type fields for date params #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsmayda
reviewed
Apr 22, 2021
rsmayda
reviewed
Apr 22, 2021
rsmayda
reviewed
Apr 22, 2021
rsmayda
approved these changes
Apr 22, 2021
rsmayda
approved these changes
Apr 22, 2021
Merged
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the date queries to work with fields of type Period(they have
startandenddatetime values). This means that queries are matching the range of the period against the implicit range of the date parameter.See the interpretation of prefixes when applied to ranges: https://www.hl7.org/fhir/search.html#prefix. It can be counterintuitive at first
Note: we rely on dynamic mapping and we don't know always know if a given field is a date or a period, so queries include clauses for both. clauses for invalid fields are simply ignored. The query results are correct, but queries can be simplified once we have static mapping and know the exact type of all fields.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.