Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

feat: Post search #70

Merged
merged 8 commits into from
Apr 14, 2021
Merged

feat: Post search #70

merged 8 commits into from
Apr 14, 2021

Conversation

Bingjiling
Copy link
Contributor

@Bingjiling Bingjiling commented Apr 8, 2021

Issue #, if available:

Description of changes:

  • Add POST for search
  • Tested with local deployment
  • Updated file mode to 755 to be in sync with other FHIR packages
  • Behavior of the parameters merge by example:
parametersInQuery parametersInBody mergedParameterResult
active=true active=false active: [true, false]
active=true active=true active: true
active=true None active: true
active=true&active=false active=false active: [true, false]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@carvantes carvantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but some changes are needed in how to handle duplicate params

src/router/routes/genericResourceRoute.ts Outdated Show resolved Hide resolved
src/router/routes/genericResourceRoute.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@rsmayda rsmayda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also plan to update the integration tests in the deployment? this is a good example of how to: awslabs/fhir-works-on-aws-deployment#284

@Bingjiling Bingjiling requested review from carvantes and rsmayda April 12, 2021 17:11
@carvantes
Copy link
Contributor

Updated file mode to 755 to be in sync with other FHIR packages

Why? by default 755 is only used for folders

e.g.

186590e08e87:fhir-works-on-aws-search-es nestorba$ stat -f '%A %N' *
644 CHANGELOG.md
644 CODE_OF_CONDUCT.md
644 CONTRIBUTING.md
644 LICENSE
644 NOTICE
644 README.md
644 THIRD-PARTY
644 jest.config.js
755 lib
755 node_modules
644 package.json
755 scripts
755 src
644 tsconfig.json
644 yalc.lock
644 yarn.lock

@Bingjiling
Copy link
Contributor Author

Updated file mode to 755 to be in sync with other FHIR packages

Why? by default 755 is only used for folders

e.g.

186590e08e87:fhir-works-on-aws-search-es nestorba$ stat -f '%A %N' *
644 CHANGELOG.md
644 CODE_OF_CONDUCT.md
644 CONTRIBUTING.md
644 LICENSE
644 NOTICE
644 README.md
644 THIRD-PARTY
644 jest.config.js
755 lib
755 node_modules
644 package.json
755 scripts
755 src
644 tsconfig.json
644 yalc.lock
644 yarn.lock

Ah! My mistake, I'll change it back.

src/router/routes/genericResourceRoute.ts Outdated Show resolved Hide resolved
src/router/routes/genericResourceRoute.ts Outdated Show resolved Hide resolved
src/router/routes/genericResourceRoute.ts Outdated Show resolved Hide resolved
@Bingjiling Bingjiling merged commit 0c29a2d into mainline Apr 14, 2021
@Bingjiling Bingjiling deleted the post-search branch April 14, 2021 01:51
@rsmayda rsmayda mentioned this pull request Jun 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants