Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

feat: add HAPI FHIR Lambda Validator #63

Merged
merged 5 commits into from
Mar 8, 2021
Merged

feat: add HAPI FHIR Lambda Validator #63

merged 5 commits into from
Mar 8, 2021

Conversation

carvantes
Copy link
Contributor

Description of changes:

Add HAPI FHIR Lambda Validator. It's mostly a wrapper that calls a lambda function and parses the response.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the size/m label Mar 4, 2021
@carvantes carvantes marked this pull request as ready for review March 4, 2021 15:51
@carvantes carvantes requested review from nguyen102 and rsmayda March 4, 2021 15:51
@nguyen102
Copy link
Contributor

Overall looks good. Same question as Robert about the java lambda timeout. Should we add code to catch and log a timeout error?

@carvantes
Copy link
Contributor Author

Overall looks good. Same question as Robert about the java lambda timeout. Should we add code to catch and log a timeout error?

If the Lambda function times out it'll result in an unhandled error, which is ok since that means that validation failed to run altogether. The default logging for unhandled errors is sufficient

@carvantes carvantes requested a review from rsmayda March 4, 2021 21:45
nguyen102
nguyen102 previously approved these changes Mar 4, 2021
View reviewed changes
@rsmayda
Copy link
Contributor

rsmayda commented Mar 5, 2021

If the Lambda function times out it'll result in an unhandled error, which is ok since that means that validation failed to run altogether. The default logging for unhandled errors is sufficient

What is the experience from an end user perspective? With API GW time out at 30 secs what is returned? HTTP code and message?

@carvantes carvantes requested review from rsmayda and removed request for rsmayda March 5, 2021 21:06
@carvantes carvantes changed the base branch from mainline to feat-igs March 8, 2021 11:33
@carvantes carvantes merged commit d22fdf2 into feat-igs Mar 8, 2021
@carvantes carvantes deleted the dev-hapi-validator branch March 8, 2021 21:29
carvantes added a commit that referenced this pull request Mar 29, 2021
@carvantes @emilhdiaz
feat: add Implementation Guides support (#66)
151228c 
* feat: compile Implementation Guides StructureDefinitions (#59)
* feat: add HAPI FHIR Lambda Validator (#63)

Co-authored-by: Emil Diaz <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rsmayda rsmayda rsmayda approved these changes

@nguyen102 nguyen102 nguyen102 left review comments

Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carvantes @nguyen102 @rsmayda