This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
feat: Add compiledImplementationGuides to FhirConfig #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilhdiaz
changed the title
Adding interfaces for compiled capability statement parts
INT-1293 - Compile IG StructureDefinitions
Feb 22, 2021
emilhdiaz
changed the title
INT-1293 - Compile IG StructureDefinitions
feat: Compile IG StructureDefinitions
Feb 22, 2021
Looks good! |
arthuston
previously approved these changes
Feb 22, 2021
2 tasks
carvantes
reviewed
Feb 24, 2021
carvantes
reviewed
Mar 3, 2021
src/profiles.ts
Outdated
Comment on lines
1
to
13
/* | ||
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
export interface ResourceCapability { | ||
type: string; | ||
supportedProfile: string[]; | ||
} | ||
|
||
export interface ResourceCapabilityStatement { | ||
[resourceType: string]: ResourceCapability; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also move this interfaces to the routing package? It looks like they are only used internally by the routing package and not anywhere else.
Going forward we'd like to keep the interface package to only the minimum required for collaboration between packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I moved these interfaces to the routing package now.
carvantes
reviewed
Mar 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
carvantes
approved these changes
Mar 5, 2021
carvantes
changed the title
feat: Compile IG StructureDefinitions
feat: Add compiledImplementationGuides to FhirConfig
Mar 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is part of a set of MRs across multiple repos for a proposal to add the ability to parse
StructureDefinitions
from IG packages and use the information found in those definitions to inject the supported FHIR profiles into the CapabilityStatement.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.