Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

feat: Add compiledImplementationGuides to FhirConfig #55

Merged
merged 4 commits into from
Mar 5, 2021

Conversation

emilhdiaz
Copy link
Contributor

This change is part of a set of MRs across multiple repos for a proposal to add the ability to parse StructureDefinitions from IG packages and use the information found in those definitions to inject the supported FHIR profiles into the CapabilityStatement.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@emilhdiaz emilhdiaz changed the title Adding interfaces for compiled capability statement parts INT-1293 - Compile IG StructureDefinitions Feb 22, 2021
@emilhdiaz emilhdiaz changed the title INT-1293 - Compile IG StructureDefinitions feat: Compile IG StructureDefinitions Feb 22, 2021
@arthuston
Copy link

Looks good!

arthuston
arthuston previously approved these changes Feb 22, 2021
src/capabilities.ts Outdated Show resolved Hide resolved
src/profiles.ts Outdated
Comment on lines 1 to 13
/*
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

export interface ResourceCapability {
type: string;
supportedProfile: string[];
}

export interface ResourceCapabilityStatement {
[resourceType: string]: ResourceCapability;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also move this interfaces to the routing package? It looks like they are only used internally by the routing package and not anywhere else.

Going forward we'd like to keep the interface package to only the minimum required for collaboration between packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, I moved these interfaces to the routing package now.

@emilhdiaz emilhdiaz requested a review from carvantes March 5, 2021 02:22
Copy link
Contributor

@carvantes carvantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@carvantes carvantes changed the title feat: Compile IG StructureDefinitions feat: Add compiledImplementationGuides to FhirConfig Mar 5, 2021
@carvantes carvantes merged commit 4aa4347 into awslabs:mainline Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants