Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

[MXAPPS-809] Configuration for Benchmark.AI Reporting. #8

Merged
merged 3 commits into from
Oct 16, 2018

Conversation

vishaalkapoor
Copy link
Contributor

@vishaalkapoor vishaalkapoor commented Oct 15, 2018

[MXAPPS-809] Configuration for Benchmark.AI reporting.

The code will follow in a separate PR. This configuration will allow customers to onboard while the code is being PR'ed.

Type: Training CV
Framework: Tensorflow
Model: ResNet-50
Benchmark: Batch size 32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this field?

Copy link
Contributor Author

@vishaalkapoor vishaalkapoor Oct 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this to be 'Benchmark Desc:' so it's clearer.

Copy link
Contributor

@larroy larroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it would be good to have code + config in the same PR though.

@vishaalkapoor
Copy link
Contributor Author

vishaalkapoor commented Oct 16, 2018

Code following in a separate PR.
The reason for splitting the config and code is to unblock those that want to add configuration and onboard to having reports.

Pedro and I chatted offline about the code and config design, and will chat further to discuss how to best to handle the configuration. The issue is that the existing task configuration exists in many different personal GitHub repos, and so there isn't a central place that collects all official tests.

As an interim, we'll use this configuration file for the benchmarks that want to be added to a report. In the future we may move or merge this to a more appropriate place.

@vishaalkapoor vishaalkapoor changed the title Configuration for Benchmark.AI Reporting. [MXAPPS-809] Configuration for Benchmark.AI Reporting. Oct 16, 2018
@indhub indhub merged commit e8c217c into awslabs:master Oct 16, 2018
mseth10 pushed a commit to mseth10/deeplearning-benchmark that referenced this pull request Feb 27, 2019
task configs for mms integration with benchmark AI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants