feat: Trino blueprint upgrade #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vara-bonthu
commented
Nov 10, 2024
| @@ -69,17 +145,4 @@ serviceAccount: | |||
| create: true | |||
| name: ${sa} | |||
| ingress: | |||
| enabled: true | |||
There was a problem hiding this comment.
Removed to avoid creating a public load balancer
ratnopamc
reviewed
Nov 12, 2024
| coordinator: | ||
| jvm: | ||
| maxHeapSize: "8G" | ||
| maxHeapSize: "32G" # ~80% of container memory |
There was a problem hiding this comment.
Can we add some description in the website doc explaining rationale behind setting these values.
There was a problem hiding this comment.
Agree! Planning to update the Trino website doc in the second PR with all the best practices.
ratnopamc
reviewed
Nov 12, 2024
Comment on lines
+107
to
+109
| - "query.max-hash-partition-count=100" # Updated from query.hash-partition-count | ||
| - "spill-enabled=true" # Updated from experimental.spill-enabled | ||
| - "spiller-spill-path=/tmp/spill" # Chagne this to SSD mount for faster |
There was a problem hiding this comment.
Can we add note in the documentation about spill to disk and how it helps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction. When we triage the issues, we will add labels to the issue like "Enhancement", "Bug" which should indicate to you that this issue can be worked on and we are looking forward to your PR. We would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
More
website/docsorwebsite/blogsection for this featurepre-commit run -awith this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes