Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Spark benchmarks update to 3.5.3 #683

Merged
merged 7 commits into from
Oct 29, 2024
Merged

feat: Spark benchmarks update to 3.5.3 #683

merged 7 commits into from
Oct 29, 2024

Conversation

vara-bonthu
Copy link
Collaborator

@vara-bonthu vara-bonthu commented Oct 28, 2024

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction. When we triage the issues, we will add labels to the issue like "Enhancement", "Bug" which should indicate to you that this issue can be worked on and we are looking forward to your PR. We would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

  • Spark Benchmarks scripts updated to use latest Spark version 3.5.3

  • Added new Spark Benchmark Dockerfile with latest libs

  • Added new managed node group for running benchmarks with graviton

  • Added new new nodepool for running benchmarks with graviton

  • Updated Spark Operator version, Karpenter addon, Karpenter resources, data addons repo

  • Fixed few issues with Llama3.1 405b model

  • Pre-commit updates to readme files

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Collaborator

@ratnopamc ratnopamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Copy link
Contributor

@alanty alanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor notes and such but LGTM. Thanks for taking on that spark image 🙌

This looks to supersede #673 so we can close that one out when this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants