Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Jupyterhub blueprint upgrade #554

Merged
merged 6 commits into from
Jun 8, 2024
Merged

feat: Jupyterhub blueprint upgrade #554

merged 6 commits into from
Jun 8, 2024

Conversation

vara-bonthu
Copy link
Collaborator

@vara-bonthu vara-bonthu commented Jun 6, 2024

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

  • Upgrading JupyterHub to use latest EKS AMI instead of Ubuntu base ami
  • Switch from NVIDIA Operator to NVIDIA Device plugin
  • Ensure timeslicing and mig works as expected
  • Update docs with instrcutions

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Collaborator

@ratnopamc ratnopamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vara-bonthu vara-bonthu changed the title WIP: Jupyterhub upgrade feat: Jupyterhub blueprint upgrade Jun 8, 2024
@vara-bonthu vara-bonthu marked this pull request as ready for review June 8, 2024 00:05
@ratnopamc
Copy link
Collaborator

I've tested this PR and time slicing works fine.

Signed-off-by: Vara Bonthu <[email protected]>
@vara-bonthu vara-bonthu merged commit a84f3b2 into main Jun 8, 2024
36 of 37 checks passed
@vara-bonthu vara-bonthu deleted the jupyterhub-upgrade branch June 8, 2024 18:20
ovaleanu pushed a commit to ovaleanu/data-on-eks that referenced this pull request Aug 10, 2024
@asmacdo
Copy link
Contributor

asmacdo commented Sep 9, 2024

@vara-bonthu Why replace Karpenter with vanilla autoscaler?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants