feat: Updates for Inferentia-Trainium workshop #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjeevrg89
changed the title
askulkarni2
changed the title
vara-bonthu
reviewed
May 28, 2024
| description = "list of role ARNs to add to the KMS policy" | ||
| type = list(string) | ||
| default = [] | ||
|
|
There was a problem hiding this comment.
remove space and run pre-commit run -a locally to format
| @@ -267,7 +267,7 @@ module "eks_data_addons" { | |||
| #--------------------------------------- | |||
| # Kuberay Operator | |||
| #--------------------------------------- | |||
| enable_kuberay_operator = true | |||
| enable_kuberay_operator = var.enable_kuberay_operator | |||
There was a problem hiding this comment.
Are you disabling Kuberay operator as a part of the workshop?
There was a problem hiding this comment.
Yes, this is a temporary fix until we can get tinylama supported via ray
There was a problem hiding this comment.
yes @vara-bonthu
| variable "enable_kuberay_operator" { | ||
| description = "Flag to enable kuberay operator" | ||
| type = bool | ||
| default = true |
There was a problem hiding this comment.
true is fine as false may break the existing blueprints
askulkarni2
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
More
website/docsorwebsite/blogsection for this featurepre-commit run -awith this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes