Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Change duplicate 100.65.0.0/16 to 100.66.0.0/16 #368

Merged
merged 1 commit into from
Nov 17, 2023
Merged

docs: Change duplicate 100.65.0.0/16 to 100.66.0.0/16 #368

merged 1 commit into from
Nov 17, 2023

Conversation

jplock
Copy link
Contributor

@jplock jplock commented Nov 17, 2023 •
edited
Loading

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Minor fix to remove duplicate CIDR range

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@jplock jplock changed the title Change duplicate 100.65.0.0/16 to 100.66.0.0/16 [docs] Change duplicate 100.65.0.0/16 to 100.66.0.0/16 Nov 17, 2023
@jplock jplock changed the title [docs] Change duplicate 100.65.0.0/16 to 100.66.0.0/16 docs: Change duplicate 100.65.0.0/16 to 100.66.0.0/16 Nov 17, 2023
askulkarni2
askulkarni2 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the fix.

@askulkarni2 askulkarni2 merged commit e64db20 into awslabs:main Nov 17, 2023
19 of 23 checks passed
@jplock jplock deleted the patch-1 branch November 17, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jplock @askulkarni2