This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
remove implicit dependency on ~/.aws/credentials #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with this change awsprocesscreds no longer needs a default profile with access keys present in ~/.aws/credentials in order to run this allows your default profile to use awsprocesscreds instead of access keys
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 5 5
Lines 315 315
Branches 42 42
=======================================
Hits 309 309
Misses 3 3
Partials 3 3
Continue to review full report at Codecov.
|
|
Thanks for the PR! This helped me to realize what was going on. While this would work, I think the proper solution is to fix the root issue in botocore itself. I created an issue in the botocore repo to track that: boto/botocore#1472 |
|
awesome, sounds good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #16
with this change awsprocesscreds no longer needs a default profile with
access keys present in ~/.aws/credentials in order to run
this allows your default profile to use awsprocesscreds instead of
access keys
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.