check execution on item when determining GetSSMParam task to use #434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Check the execution defined on the launch/stack etc. as well as the global execution_mode
I'm not sure if the hasattr check is required, however as this is defined in child classes I thought it would be safer, happy to remove though
Currently as execution_mode is checked, within the spoke CodeBuild job of the puppet account, hub products are being launched and are failing to retrieve the SSM parameters as they have not been previously cached.
This worked previously when
self.execution = "hub" and parameter_is_in_hub = True
, as it will have gone into the standardGetSSMParamTask
However now that
self.execution_mode
is checked, when a hub product is processed,self.execution_mode = "spoke" and parameter_is_in_hub = True
, so it'll drop intoGetSSMParamFromManifestTask
I'm going to look through the logs to confirm whether the hub products were actually being launched before.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.