Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check execution on item when determining GetSSMParam task to use #434

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

RobBrazier
Copy link
Contributor

Issue #, if available:

Description of changes:
Check the execution defined on the launch/stack etc. as well as the global execution_mode

I'm not sure if the hasattr check is required, however as this is defined in child classes I thought it would be safer, happy to remove though

Currently as execution_mode is checked, within the spoke CodeBuild job of the puppet account, hub products are being launched and are failing to retrieve the SSM parameters as they have not been previously cached.

This worked previously when self.execution = "hub" and parameter_is_in_hub = True, as it will have gone into the standard GetSSMParamTask

However now that self.execution_mode is checked, when a hub product is processed, self.execution_mode = "spoke" and parameter_is_in_hub = True, so it'll drop into GetSSMParamFromManifestTask

I'm going to look through the logs to confirm whether the hub products were actually being launched before.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@RobBrazier
Copy link
Contributor Author

i'm not sure whether there's an environment issue - make install works fine when I run it locally, I did see a similar issue pypa/setuptools#2775 that's been around recently - I'm running python 3.9, wonder if it's related to 3.7?

@eamonnfaherty
Copy link
Contributor

I have spotted the same issue. it has broken the coverage reporting. I have to move off python 3.7. I am hoping to get that done next week.

@eamonnfaherty eamonnfaherty merged commit 4488b1a into awslabs:master Sep 23, 2021
@RobBrazier RobBrazier deleted the check-item-execution branch September 23, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants