Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cargo_audit_flags related to the chrono crate #646

Closed
wants to merge 2 commits into from

Conversation

ysaito1001
Copy link
Collaborator

@ysaito1001 ysaito1001 commented Oct 25, 2022

Motivation and Context

This PR will remain a draft to avoid getting merged inadvertently until an issue submitted for aws-doc-sdk-examples has been resolved. Merge #654 to this PR first before merging this PR to main.

This PR removes --ignore flags for cargo audit related to the chrono crate.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This commit removes --ignore flags for cargo audit related to the chrono
crate. It is an accompanying PR for
smithy-lang/smithy-rs#1907
@DavidSouther
Copy link
Contributor

This is blocked on the SDK fixing their use of Chrono in aws-smithy-types-convert. Track also chronotope/chrono#602

@ysaito1001
Copy link
Collaborator Author

Will close this draft PR. Cargo audit issues need to be handled by smithy-rs and aws-doc-sdk-examples separately before artifacts from both places make it to aws-sdk-rust repo. In other words, running cargo audit only in the aws-sdk-rust is too late and does not prevent new vulnerabilities from being introduced from either place.

smithy-rs keeps track of it via this issue. aws-doc-sdk-examples needs to address this issue.

@ysaito1001 ysaito1001 closed this Apr 5, 2023
@ysaito1001 ysaito1001 deleted the ysaito/fix-cargo-audit-issue-on-chrono branch March 15, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants