Update README to link to the developer guide #325

rcoh · 2021-12-07T00:38:36Z

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The old guide: https://github.com/awslabs/aws-sdk-rust/blob/main/Guide.md has been deleted and changed to: https://docs.aws.amazon.com/sdk-for-rust/latest/dg/welcome.html See: awslabs/aws-sdk-rust#325 Signed-off-by: bin liu <[email protected]>

* Update README.md to fix invalid Developer Guide URL The old guide: https://github.com/awslabs/aws-sdk-rust/blob/main/Guide.md has been deleted and changed to: https://docs.aws.amazon.com/sdk-for-rust/latest/dg/welcome.html See: awslabs/aws-sdk-rust#325 Signed-off-by: bin liu <[email protected]> * Update invalid Developer Guide URL in AwsReadmeDecorator.kt The old guide: https://github.com/awslabs/aws-sdk-rust/blob/main/Guide.md has been deleted and changed to: https://docs.aws.amazon.com/sdk-for-rust/latest/dg/welcome.html See: awslabs/aws-sdk-rust#325 Signed-off-by: bin liu <[email protected]> * Add fixing Developer Guide link to CHANGELOG.next.toml Signed-off-by: bin liu <[email protected]> Co-authored-by: Russell Cohen <[email protected]>

* Update README.md to fix invalid Developer Guide URL The old guide: https://github.com/awslabs/aws-sdk-rust/blob/main/Guide.md has been deleted and changed to: https://docs.aws.amazon.com/sdk-for-rust/latest/dg/welcome.html See: #325 Signed-off-by: bin liu <[email protected]> * Update invalid Developer Guide URL in AwsReadmeDecorator.kt The old guide: https://github.com/awslabs/aws-sdk-rust/blob/main/Guide.md has been deleted and changed to: https://docs.aws.amazon.com/sdk-for-rust/latest/dg/welcome.html See: #325 Signed-off-by: bin liu <[email protected]> * Add fixing Developer Guide link to CHANGELOG.next.toml Signed-off-by: bin liu <[email protected]> Co-authored-by: Russell Cohen <[email protected]>

* [autosync] Improve Pokémon Service `Makefile` (#1264) * Improve Pokémon Service `Makefile` * Code-generate only the Pokémon Service SDK (as opposed to all targets in the `codegen-server-test` subproject like we do currently). * Add `run` target to run the service. * Add `doc-open` target to generate and open Rustdoc documentation. * Bring back client generation Co-authored-by: Matteo Bigoi <[email protected]> * [autosync] Fix bug where where format argument is not a literal string (#1266) * [autosync] Fix developer guide URL (#1262) * Update README.md to fix invalid Developer Guide URL The old guide: https://github.com/awslabs/aws-sdk-rust/blob/main/Guide.md has been deleted and changed to: https://docs.aws.amazon.com/sdk-for-rust/latest/dg/welcome.html See: #325 Signed-off-by: bin liu <[email protected]> * Update invalid Developer Guide URL in AwsReadmeDecorator.kt The old guide: https://github.com/awslabs/aws-sdk-rust/blob/main/Guide.md has been deleted and changed to: https://docs.aws.amazon.com/sdk-for-rust/latest/dg/welcome.html See: #325 Signed-off-by: bin liu <[email protected]> * Add fixing Developer Guide link to CHANGELOG.next.toml Signed-off-by: bin liu <[email protected]> Co-authored-by: Russell Cohen <[email protected]> * [autosync] Make two functions private in `HttpBoundProtocolGenerator.kt` (#1254) * [autosync] Remove unused `async-stream` dependency from `CargoDependency.kt` (#1249) * [autosync] Update to Rust Edition 2021 (#1268) * update: set rust edition to 2021 update: strict param of intoCrate to set clippy to set #![deny(clippy::all)] * add: changelog entry * [autosync] fix: incorrect issue reference (#1270) * [autosync] Bugfix: prevent errors like "move occurs because `input.element` has type `Blob`, which does not implement the `Copy` trait" (#1269) Signed-off-by: Bigo <[email protected]> Co-authored-by: Russell Cohen <[email protected]> * [autosync] Add miscellaneous protocol test with nested required shape (#1267) This commit adds another suite of protocol tests to test miscellaneous aspects of code generation where protocol selection should not be relevant. The first test is code-generating an operation with a nested required shape, minimally reproducing the bug that was fixed in 75056c, so that we don't regress on it. I've added it to both the `codegen-test` and `codegen-server-test` subprojects, even though the bug only affected the server, in part to also incentivize us into adding more tests to this Smithy model for both clients and servers. * [autosync] Fix serialization of required shapes (timestamps and nested shapes) (#1275) In #1148, `@required` started being strictly interpreted by server SDKs. That meant that when serializing values from structures, we no longer borrow for every shape when looking into `Option`s as in: ``` if let Some(var_37) = &input.value ``` (See for example `RustWriter.serializeStructure` from `JsonSerializerGenerator.kt` for the relevant serialization code-generation routine) Instead, we attempt to serialize the unborrowed required shape value. This works well for booleans, numeric types (since they are `Copy`), collections (since we borrow their items while iterating), and strings (since we call `as_str()`). It also worked for unions and documents, since we already borrowed (note that `ValueExpression.kt` makes sure to not borrow twice if the value is already a reference, like when clients look into `Option`s). We fixed borrowing of blobs in #1269. However, we currently don't borrow for timestamps and nested shapes. This commit fixes that, and adds a comprehensive protocol test to ensure we exercise all the lines relevant to serialization of required shapes. * [autosync] Move `SmithyHttpServer` to `ServerCargoDependency.kt` (#1248) * Move `SmithyHttpServer` to `ServerCargoDependency.kt` * fix Co-authored-by: Russell Cohen <[email protected]> * [autosync] Rename `ServerHttpProtocolGenerator` to `ServerHttpBoundProtocolGenerator` (#1251) And `ServerHttpProtocolImplGenerator` to `ServerHttpBoundProtocolTraitImplGenerator`. The client-side classes are named `HttpBoundProtocolGenerator` and `HttpBoundProtocolTraitImplGenerator`, so the server-side clases should just add the "Server" prefix and not deviate from the naming convention. * [autosync] Use Docker build image in CI (#1255) Establishes a Docker build image with build tools precompiled into it to improve CI time and reduce GitHub Actions workflow configuration. Also makes it possible to run the exact CI workflows in local development. * [autosync] Fix image acquisition when CI is run outside of a pull request (#1280) * [autosync] Fix path on git command (#1281) * [autosync] fix: treat blank env credentials as missing (#1272) * [autosync] Update pinned nightly to fix `cargo udeps` checks (#1285) * Update pinned nightly to fix `cargo udeps` checks * Update `api-linter` to work on `nightly-2022-03-29` * Make it possible to test tool modifications in a pull request * [autosync] Update node dependencies (#1282) * [autosync] Simplify CI with composite actions and new image tagging approach (#1283) - Refactors CI to use composite actions so that there's less duplication in the workflow yaml files. - Switches to a different image tagging approach for the Docker build image: now the git hash of the `tools/` directory is the image tag rather than the commit hash of `HEAD`. This will result in more image reuse if the tools haven't changed, and makes the logic for deciding whether a new image must be built much simpler. - When running CI on main, ensures the Docker build image is built and uploaded to ECR before running the CI tests. * [autosync] Fix GitHub Actions workflow reference in `ci-main` (#1286) * [autosync] Improve AssumeRoleProvider (#1296) This adds to improvements to `AssumeRoleProvider`: 1. This adds a cache aroudn this provider. Since this provider is intended to be used directly by customers, it should be cached to improve performance and predictability. 2. Add support for configuring the role session length. * [autosync] Split codegen tests out into their own job (#1298) * [autosync] Enable "TODOs" lint for server code (#1292) Stale TODOs have been removed and new tracking issues have been cut to provide context to the others. * [autosync] aws-smithy-query: bump to urlencoding v2.1 (#1301) * aws-smithy-query: bump to urlencoding v2.1 * Add changelog entry for urlencoding update Co-authored-by: Russell Cohen <[email protected]> * [autosync] Add throttling retry to Docker build image pull (#1297) * [autosync] Smithy async docs (#1278) * Add lints to aws-smithy-async * Write some event stream docs, and enable lints * Codegen docs * Fix one missing doc * Compile fixes * remove accidentally added code * Update codegen/src/main/kotlin/software/amazon/smithy/rust/codegen/smithy/SymbolVisitor.kt * Update response headers docs * [autosync] Enable running the canary with a path to a generated SDK (#1303) * [autosync] Add more debug info to `acquire-build-image` (#1305) * [autosync] Enable deploying a minimal set of resources for running the canary (#1306) * [autosync] Combine PR bot messages into one (#1299) * [autosync] Remove `impl_extension_new_and_deref` macro from `aws-smithy-http-server` (#1290) This macro is used only once in the codebase. * [autosync] Make `builderSymbol` return a `Symbol` (#1312) It currently returns a `RuntimeType`. It makes no actual difference whatsoever, but `RuntimeType` is kept for types we don't code-generate, but that we use from other crates. * [autosync] Migrate from `structopt` to `clap` v3 (#1293) `clap` v3 added support for a `structopt`-like parser derive usage. `structopt` is now in maintenance mode (https://docs.rs/structopt/latest/structopt/#maintenance); it is recommended to migrate to `clap`. Structs to parse CLI arguments have been renamed to `Args` for consistency. * [autosync] Add endpoint resolver to SdkConfig (#1300) * Add endpoint resolver to SdkConfig This commit adds an `endpoint_resolver` field to SdkConfig, which flows through to the `endpoint_resolver` field on each individual service configuration. To avoid a circular dependency between the aws-types crate and the aws-endpoint crate, the `AwsEndpoint` type and its dependencies are moved from the aws-endpoint crate to the aws-types crate, then rexported in aws-endpoint. Fix aws-labs/aws-sdk-rust#396. * impl From<'static str> for signing service and signing region * Code generate for the static string implementation * Add EndpointResolver to aws_config * Add docs and adapt test * Fix test * Fix endpoint config customizations test to remove dead code * Re-add `.set_endpoint` * Remove print and update changelog Co-authored-by: Russell Cohen <[email protected]> * [autosync] Generate a `versions.toml` with the SDK (#1311) * Implement `crate-hasher` utility to hash crate source files * Add `generate-version-manifest` subcommand to publisher tool * Incorporate `generate-version-manifest` into the build system * Start making the PR bot run through the Docker build image * Use nightly clippy in tools CI when necessary * Fix transient failure when acquiring the build image * Include examples repo revision in `versions.toml` * Fix nightly clippy lint in `cargo-api-linter` * Track examples revision in sync tool * Make it easier to run Docker CI locally * [autosync] Rename `serverOperationHandler` to `OperationHandler` in `ServerRuntimeType.kt` (#1291) All other members start with an uppercase letter, and the "server" prefix is not necessary since they are namespaced under a server-specific file. * [autosync] Prepare for 2022-04-13 release (#1317) * update: models for release * update: Changelogs for release update: gradle properties for release Co-authored-by: david-perez <[email protected]> Co-authored-by: Matteo Bigoi <[email protected]> Co-authored-by: Bin Liu <[email protected]> Co-authored-by: Russell Cohen <[email protected]> Co-authored-by: John DiSanti <[email protected]> Co-authored-by: Rob Speller <[email protected]> Co-authored-by: Nikhil Benesch <[email protected]>

Update README to link to the developer guide

773a016

rcoh requested a review from jdisanti December 7, 2021 00:38

rcoh requested a review from a team as a code owner December 7, 2021 00:38

rcoh added 2 commits December 6, 2021 19:39

Delete Guide.md

1b4a263

Update ---questions-help.md

a167fd1

jdisanti approved these changes Dec 7, 2021

View reviewed changes

rcoh merged commit 6feb50d into main Dec 7, 2021

Velfi deleted the readme-developer-guide branch December 7, 2021 16:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update README to link to the developer guide #325

Update README to link to the developer guide #325

rcoh commented Dec 7, 2021

Update README to link to the developer guide #325

Update README to link to the developer guide #325

Conversation

rcoh commented Dec 7, 2021