Outdated aws_smithy_runtime::client::http::hyper_014::HyperConnector rustdoc example referencing DefaultHttpsTcpConnector

[declanvk]

Describe the issue

As the title says, there is a rustdoc referencing a non-existent type DefaultHttpsTcpConnector in:

aws-sdk-rust/sdk/aws-smithy-runtime/src/client/http/hyper_014.rs

Lines 132 to 143 in 3cb1d76

	/// ```no_run,ignore
	/// use aws_smithy_runtime::client::connectors::hyper_connector::{DefaultHttpsTcpConnector, HyperConnector};
	///
	/// let hyper_connector = HyperConnector::builder().build(DefaultHttpsTcpConnector::new());
	///
	/// // This connector can then be given to a generated service Config
	/// let config = my_service_client::Config::builder()
	/// .endpoint_url("http://localhost:1234")
	/// .http_connector(hyper_connector)
	/// .build();
	/// let client = my_service_client::Client::from_conf(config);
	/// ```

I think that instead this should be instead be something directly from the hyper crate, similar to what is used in the tests:

aws-sdk-rust/sdk/aws-smithy-runtime/tests/reconnect_on_transient_error.rs

Lines 128 to 130 in 3cb1d76

	.build(hyper_0_14::client::HttpConnector::new_with_resolver(
	mock.dns_resolver(),
	));

Links

• https://docs.rs/aws-smithy-runtime/1.0.2/aws_smithy_runtime/client/http/hyper_014/struct.HyperConnector.html#examples

[jdisanti]

Thanks for reporting this! Working on a fix.

[jdisanti]

This will be fixed in an upcoming release.

[declanvk]

This will be fixed in an upcoming release.

Thank you for the quick work!

[jdisanti]

The fix for this went out in the December 14th release.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.