Add code to convert ALB events to http.Request and http.ResponseWriter #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding adapter code changes for processing of ALB events |
choonkeat
reviewed
Jul 10, 2024
| if queryString != "" { | ||
| queryString += "&" | ||
| } | ||
| queryString += url.QueryEscape(q) + "=" + url.QueryEscape(v) |
There was a problem hiding this comment.
I think req.MultiValueQueryStringParameters carries raw (already escaped) values
Suggested change
| queryString += url.QueryEscape(q) + "=" + url.QueryEscape(v) | |
| queryString += q + "=" + v |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of code in the core library of RequestAccessorALB and ProxyResponseWriterALB . These 2 types will allow conversion of ALBTargetGroupRequest and ALBTargetGroupResponse to http.Request and http.ResponseWriter. This core library allows for easy integration with common go frameworks such as Gin, Fiber or Routers like negroni or Gorillamux. Samples for just ALB will be added in seperate folder for now. I was not sure this code goes in this library. Maybe aws-lambda-go-alb-proxy makes more sense?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.