Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added request PathParameter to context #154

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

reecerussell
Copy link

Issue #, if available: #153

Description of changes:

Similar to how the stage variables support is implemented, I've added support for accessing path parameters through the request context and header.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@reecerussell
Copy link
Author

Hey @sapessi, would it be possible to get a review on this?

I'm using a fork at the moment which is a bit painful 😜

Copy link
Contributor

@drakejin drakejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whole test code it's nice. but, some test case It's weired I think. Would plz check again?
oops. I missed the point. sorry.


It's duplicated issue #121 @sapessi need to check this PR

@reecerussell
Copy link
Author

@sapessi wanted to follow up on this, as this would be a good change to get in. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants