Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json support for java8 datetimes #320

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

amcquistan
Copy link

@amcquistan amcquistan commented Jan 7, 2024

Issue: #202

Description of changes: Configurable support for Java 8 Dates in JSON

Adds support for a ObjectMapperFactory interface and property configuration driven extensibility for JSON support through ObjectMapper with a DefaultObjectMapperFactory implementation

New Configuration Properties: registerJavaTimeModule and objectMapperFactory

New Constants: AwsSchemaRegistryConstants

/**
     * Jackson Java Time Module to use for handling Java 8 Date/Time.
     * By default, no module is registered.
     * Ex: com.fasterxml.jackson.datatype.jsr310.JavaTimeModule
     */
    public static final String REGISTER_JAVA_TIME_MODULE = "registerJavaTimeModule";

    /**
     * Factory for creating custom Jackson ObjectMapper instances for use in handling JSON.
     * Default: com.amazonaws.services.schemaregistry.utils.json.DefaultObjectMapperFactory
     */
    public static final String OBJECT_MAPPER_FACTORY = "objectMapperFactory";

@YangSan0622
Copy link
Contributor

Do you mind squash your commits and resolve the conflict when you have a chance? We will start reviewing this PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants