Feat: Allow param filename configuration per target with the CFn provider + bugfixes #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ider **Why?** Allowing a specific parameter file to be used. This is especially useful if you would like to reuse a template. Often these templates are committed or generated with another generator than generate_params.py. **What?** * Added params_filename to the CloudFormation provider schema. * Updated the CloudFormation provider to support setting the params_filename. * Documented the param_filename property in the CloudFormation provider docs.
StewartW
approved these changes
Dec 12, 2022
javydekoning
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Allowing a specific parameter file to be used. This is especially useful if you
would like to reuse a template. Often these templates are committed or generated
with another generator than
generate_params.py.What?
params_filenameto the CloudFormation provider schema.params_filename.param_filenameproperty in the CloudFormation provider docs.Additionally, I refactored the
adf_codepipeline.pyfile. As this file was not followingthe line length requirements. When the line length was updated before, the resulting
code was hardly readable.
After this change, I realized a number of the properties were not configured correctly.
It would use the default_provider configuration first, and when that was not set
it would fallback to the target properties. However, it should be configured the other
way around. Use the target properties first, and fallback to the default_provider
properties second, and fallback to a default value as a last resort.
The properties where this was incorrectly configured were:
bucket_name,extract, andobject_key.function_nameandinput.application_nameanddeployment_group_name.By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.